Re: [PATCH v2] net: stmmac: fix a possible endless loop

From: David Miller
Date: Thu Feb 06 2020 - 09:50:36 EST


From: Dejin Zheng <zhengdejin5@xxxxxxxxx>
Date: Thu, 6 Feb 2020 22:18:11 +0800

> It forgot to reduce the value of the variable retry in a while loop
> in the ethqos_configure() function. It may cause an endless loop and
> without timeout.
>
> Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos")
>
> Signed-off-by: Dejin Zheng <zhengdejin5@xxxxxxxxx>
> Acked-by: Vinod Koul <vkoul@xxxxxxxxxx>
> ---
>
> Vinod Koul and David Miller, Thanks for your comments!
>
> V2:
> add an appropriate Fixes tag.

Please do not put an empty line between Fixes and other tags.

I have no idea why people often do this.

Anyways, Fixes and other tags are all tags and thus belong together as
an uninterrupted group of text.

Thank you.