Re: [PATCH v2,RESEND] MIPS: Scan the DMI system information

From: Jiaxun Yang
Date: Thu Feb 06 2020 - 02:05:01 EST




> On Wed, 05 Feb 2020 10:55:38 +0800, Jiaxun Yang wrote:
>
>>> I think it is better to split it into the following two patches?
>>> [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
>>> [PATCH v3 2/2] MIPS: Add support for Desktop Management Interface (DMI)
>>
>> That way will break bisect.
>
> Are you sure? As far as I can see, each patch builds individually. The
> dmi patch is a no-op alone. The mips patch will not work alone,
> obviously, however according to Tiezhu dmi_scan_machine() will fail
> with a harmless error message if the base address is 0xF0000. If that's
> correct then it's not breaking bisect.

Sorry, I even forgot that it's my modification :-)
Just don't want to trouble maintainers so much.

>
> --
> Jean Delvare
> SUSE L3 Support
--
Jiaxun Yang