Re: [PATCH v2,RESEND] MIPS: Scan the DMI system information

[Tiezhu Yang]

On 2/5/20 10:55 AM, Jiaxun Yang wrote:
> > On 2/3/20 8:14 PM, Jean Delvare wrote:
> >
> > > Hi Tiezhun,
> > >
> > > On Mon, 3 Feb 2020 16:32:03 +0800, Tiezhu Yang wrote:
> > >
> > > > On 1/16/20 9:26 PM, Tiezhu Yang wrote:
> > > >
> > > > > Enable DMI scanning on the MIPS architecture, this setups DMI identifiers
> > > > > (dmi_system_id) for printing it out on task dumps and prepares DIMM entry
> > > > > information (dmi_memdev_info) from the SMBIOS table. With this patch, the
> > > > > driver can easily match various of mainboards.
> > > > >
> > > > > In the SMBIOS reference specification, the table anchor string "_SM_" is
> > > > > present in the address range 0xF0000 to 0xFFFFF on a 16-byte boundary,
> > > > > but there exists a special case for Loongson platform, when call function
> > > > > dmi_early_remap, it should specify the start address to 0xFFFE000 due to
> > > > > it is reserved for SMBIOS and can be normally access in the BIOS.
> > > > >
> > > > > This patch works fine on the Loongson 3A3000 platform which belongs to
> > > > > MIPS architecture and has no influence on the other architectures such
> > > > > as x86 and ARM.
> > > > >
> > > > > Co-developed-by: Yinglu Yang <yangyinglu@xxxxxxxxxxx>
> > > > > Signed-off-by: Yinglu Yang <yangyinglu@xxxxxxxxxxx>
> > > > > [jiaxun.yang@xxxxxxxxxxx: Refine definitions and Kconfig]
> > > > > Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> > > > > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> > > > > Reviewed-by: Huacai Chen <chenhc@xxxxxxxxxx>
> > > > > ---
> > > > >
> > > > > v2:
> > > > > - add SMBIOS_ENTRY_POINT_SCAN_START suggested by Jean
> > > > > - refine definitions and Kconfig by Jiaxun
> > > > >
> > > > > arch/mips/Kconfig | 10 ++++++++++
> > > > > arch/mips/include/asm/dmi.h | 20 ++++++++++++++++++++
> > > > > arch/mips/kernel/setup.c | 2 ++
> > > > > drivers/firmware/dmi_scan.c | 6 +++++-
> > > > > 4 files changed, 37 insertions(+), 1 deletion(-)
> > > > > create mode 100644 arch/mips/include/asm/dmi.h
> > > > Hi Paul and Jean,
> > > >
> > > > How do you think this patch?
> > > Looks good to me and you can add:
> > >
> > > Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>
> > >
> > > for the dmi subsystem part.
> > >
> > > > Should I split it into the following two patches?
> > > > [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
> > > > [PATCH v3 2/2] MIPS: Add support for Desktop Management Interface (DMI)
> > > >
> > > > The first patch is only related with the common dmi code
> > > > drivers/firmware/dmi_scan.c, the other patch is only related
> > > > with the mips code under arch/mips.
> > > >
> > > > If you have any questions or suggestions, please let me know.
> > > > I am looking forward to your early reply.
> > > I'm fine either way. I you do not split it, as most changes are in the
> > > mips arch files and I do not expect any conflict in the dmi subsystem
> > > part, I believe that the patch should be merged by the mips arch
> > > maintainer.
> > Hi Jean,
> >
> > Thanks very much for your review.
> >
> > As described in another mail [1] by MIPS maintainer Paul Burton:
> >
> > "So if unmerged arch/mips/ patches are holding you up, ping me, but
> > preferrably make sure code being added actually belongs under arch/mips/
> > first."
> >
> > I think it is better to split it into the following two patches?
> > [PATCH v3 1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START
> > [PATCH v3 2/2] MIPS: Add support for Desktop Management Interface (DMI)
> Hi Tiezhu,
>
> That way will break bisect. In this case, I think the patch should still go through MIPS
> tree after grab review or ack from DMI maintainer.
>
> There is a grey margin for tree-wide patches, we should discuss how to deal with them case by
> case, for the email you mentioned, the main focus is platform driver.


Hi Jiaxun,


Sorry for the late reply.

I just saw your email a moment ago, and already sent the split v3 patch.

https://lore.kernel.org/patchwork/patch/1189713/

https://lore.kernel.org/patchwork/patch/1189714/

Let us wait and hear the opinion of Paul.


Hi Paul,

How do you think this case? One patch or two patches?

If one patch is better, I will send a v4 patch to make MIPS DMI config

depend on MACH_LOONGSON64.


Hi Jean,

Please do not merge the following patch until we hear the opinion of Paul:

[PATCH v3,1/2] firmware: dmi: Add macro SMBIOS_ENTRY_POINT_SCAN_START

https://lore.kernel.org/patchwork/patch/1189713/


Thanks,


Tiezhu Yang


> Thanks.
>
> --
>
> Jiaxun Yang