Re: [PATCH] KVM: nVMX: Remove stale comment from nested_vmx_load_cr3()

From: linmiaohe
Date: Tue Feb 04 2020 - 20:57:59 EST


Sean Christopherson <sean.j.christopherson@xxxxxxxxx> writes:
> The blurb pertaining to the return value of nested_vmx_load_cr3() no longer matches reality, remove it entirely as the behavior it is attempting to document is quite obvious when reading the actual code.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> - * Returns 0 on success, 1 on failure. Invalid state exit qualification code
> - * is assigned to entry_failure_code on failure.
> */
> static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool nested_ept,
> u32 *entry_failure_code)

It seems the comment is uncorrect as it return -EINVAL on failure. Thanks.

Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>