Re: [PATCH] initramfs: do not show compression mode choice if INITRAMFS_SOURCE is empty

From: Arvind Sankar
Date: Mon Feb 03 2020 - 15:07:03 EST


On Tue, Feb 04, 2020 at 01:47:08AM +0900, Masahiro Yamada wrote:
> Since commit ddd09bcc899f ("initramfs: make compression options not
> depend on INITRAMFS_SOURCE"), Kconfig asks the compression mode for
> the built-in initramfs regardless of INITRAMFS_SOURCE.
>
> It is technically simpler, but pointless from a UI perspective,
> Linus says [1].
>
> When INITRAMFS_SOURCE is empty, usr/Makefile creates a tiny default
> cpio, which is so small that nobody cares about the compression.
>
> This commit hides the Kconfig choice in that case. The default cpio
> is embedded without compression, which was the original behavior.
>
> [1]: https://lkml.org/lkml/2020/2/1/160
>
> Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---

Would it be feasible to check if the kernel is going to be compressed,
i.e. one of the KERNEL_{GZIP,BZIP2,...} options other than
KERNEL_UNCOMPRESSED is set, and default built-in initramfs to
uncompressed in that case as well?

Thanks.