Re: [PATCH -next] watchdog: fix mtk_wdt.c RESET_CONTROLLER build error

From: Guenter Roeck
Date: Mon Feb 03 2020 - 12:49:43 EST


On Mon, Feb 03, 2020 at 08:10:29AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix build error when CONFIG_RESET_CONTROLLER is not set by
> selecting RESET_CONTROLLER.
>
> ld: drivers/watchdog/mtk_wdt.o: in function `mtk_wdt_probe':
> mtk_wdt.c:(.text+0x3ec): undefined reference to `devm_reset_controller_register'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> Cc: linux-watchdog@xxxxxxxxxxxxxxx

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20200203.orig/drivers/watchdog/Kconfig
> +++ linux-next-20200203/drivers/watchdog/Kconfig
> @@ -841,6 +841,7 @@ config MEDIATEK_WATCHDOG
> tristate "Mediatek SoCs watchdog support"
> depends on ARCH_MEDIATEK || COMPILE_TEST
> select WATCHDOG_CORE
> + select RESET_CONTROLLER
> help
> Say Y here to include support for the watchdog timer
> in Mediatek SoCs.
>
>