Re: [PATCH 1/1] media: si470x-i2c: Move free() past last use of 'radio'

From: Greg KH
Date: Mon Feb 03 2020 - 09:32:49 EST


On Mon, Feb 03, 2020 at 01:21:30PM +0000, Lee Jones wrote:
> A pointer to 'struct si470x_device' is currently used after free:
>
> drivers/media/radio/si470x/radio-si470x-i2c.c:462:25-30: ERROR: reference
> preceded by free on line 460
>
> Shift the call to free() down past its final use.
>
> NB: Not sending to Mainline, since the problem does not exist there.

It doesn't exist there because of a bad merge? What commit caused the
problem?

thanks,

greg k-h