Re: [PATCH V2 2/5] spi: fspi: dynamically alloc AHB memory

[Adam Ford]

On Sun, Feb 2, 2020 at 10:39 AM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> On Sun, Feb 2, 2020 at 10:00 AM Adam Ford <aford173@xxxxxxxxx> wrote:
> >
> > From: Han Xu <han.xu@xxxxxxx>
> >
> > Apply patch from NXP upstream repo to
> > dynamically allocate AHB memory as needed.
>
> The commit log could be improved here. What is the motivation for doing this?

My motivation is to get the flexspi on the i.MX8MM to work, and I did
a list of the patches applied on the NXP branch to see what was
applied on top of their 4.19 kernel and this patch series generated
from that list.  Most of the NXP commits are one-line commits, and I
don't know the motivation for what's happening.  NXP did it, and I
know it works on the Flexspi driver.

Maybe Han Xu can comment, since it's really his patch.


adam
>
> > +               if (!f->ahb_addr) {
> > +                       dev_err(f->dev, "failed to alloc memory\n");
>
> There is no need for this error message as the MM core will take care of it.