Re: [PATCHv2 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML

[Sai Prakash Ranjan]

On 2020-02-02 10:13, Stephen Boyd wrote:
> Quoting Sai Prakash Ranjan (2020-02-01 07:29:48)
> > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml 
> > b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> > new file mode 100644
> > index 000000000000..5448cc537a03
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
> > +
> > +maintainers:
> > +  - Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: watchdog.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - qcom,kpss-timer
> > +      - qcom,kpss-wdt
> > +      - qcom,kpss-wdt-apq8064
> > +      - qcom,kpss-wdt-ipq4019
> > +      - qcom,kpss-wdt-ipq8064
> > +      - qcom,kpss-wdt-msm8960
> > +      - qcom,scss-timer
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
>
> By the way, I would expect the watchdog to have an interrupt property.
> Not sure why it isn't described in the existing binding.

Yes it should be an optional property now that bark interrupt support 
has been added. I will add that in a separate patch.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation