Re: [PATCH] powerpc/32s: Don't flush all TLBs when flushing one page

From: Segher Boessenkool
Date: Sat Feb 01 2020 - 11:18:14 EST


On Sat, Feb 01, 2020 at 03:53:12PM +0100, Christophe Leroy wrote:
> >>No, in end the low bits are set, that's a BIT OR with ~PAGE_MASK, so it
> >>sets all low bits to 1.
> >
> >Oh, wow, yes, I cannot read apparently.
> >
> >Maybe there are some ROUND_DOWN and ROUND_UP macros you could use?
>
> Yes but my intention was to modify the existing code as less as possible.
> What do you think about version v2 of the patch ?

It looked fine to me.

Add my

Reviewed-by: Segher Boessenkool <segher@xxxxxxxxxxxxxxxxxxx>

if you want.


Segher