Re: [PATCH v4 2/2] kasan: add test for invalid size in memmove

From: Walter Wu
Date: Thu Jan 30 2020 - 21:54:29 EST


On Thu, 2020-01-30 at 18:16 -0800, Andrew Morton wrote:
> On Thu, 30 Jan 2020 11:43:58 +0800 Walter Wu <walter-zh.wu@xxxxxxxxxxxx> wrote:
>
> > On Fri, 2019-11-22 at 06:21 +0800, Andrey Ryabinin wrote:
> > >
> > > On 11/12/19 9:53 AM, Walter Wu wrote:
> > > > Test negative size in memmove in order to verify whether it correctly
> > > > get KASAN report.
> > > >
> > > > Casting negative numbers to size_t would indeed turn up as a large
> > > > size_t, so it will have out-of-bounds bug and be detected by KASAN.
> > > >
> > > > Signed-off-by: Walter Wu <walter-zh.wu@xxxxxxxxxxxx>
> > > > Reviewed-by: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> > >
> > > Reviewed-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
> >
> > Hi Andrey, Dmitry, Andrew,
> >
> > Would you tell me why this patch-sets don't merge into linux-next tree?
> > We lost something?
> >
>
> In response to [1/2] Andrey said "So let's keep this code as this" and
> you said "I will send a new v5 patch tomorrow". So we're awaiting a v5
> patchset?
>

Hi Andrew,

The [1/2] patch discussion shows below. Thanks for Dimitry help to
explain it. So that v4 patchset got Andrey's signature. Because I see
Andrey said "But I see you point now. No objections to the patch in that
case."

@Andrey, if I have an incorrect understanding, please let me know.
Thanks for your help.

https://lkml.org/lkml/2019/11/21/1019
https://lkml.org/lkml/2019/11/21/1020


Walter