Re: [PATCH V5] firmware: arm_scmi: Make scmi core independent of the transport type

From: Viresh Kumar
Date: Thu Jan 30 2020 - 04:41:19 EST


On 30-01-20, 10:25, Etienne Carriere wrote:
> I've made a first port (draft) for adding new transport channels, next
> to existing mailbox channel, on top of your change.
> You can find it here: https://github.com/etienne-lms/linux/pull/1.
>
> I don't have specific comments on your change but the one below.
> I think SMT header should move out of mailbox.c, but that may be a bit
> out of the scope of your change.

If it is guaranteed that someone will end up using those routines
apart from mailbox.c, then surely it can be done.

> I would prefer an optional mak_txdone callback:
>
> if (info->desc->ops->mark_txdone)
> info->desc->ops->mark_txdone(cinfo, ret);

So you are sure that mark_txdone won't be required in your case? I can
make it optional then.

--
viresh