Re: [PATCH 3/4] i2c: cadence: Implement save restore

From: Wolfram Sang
Date: Thu Jan 30 2020 - 03:21:06 EST


On Mon, Dec 09, 2019 at 04:10:51PM +0530, shubhrajyoti.datta@xxxxxxxxx wrote:
> From: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
>
> Implement save restore for i2c module.
> Since we have only a couple of registers
> an unconditional restore is done.

The patch description misses an explanation *why* this is needed. From a
distance looks like a bugfix, so a Fixes tag may be needed, too.

>
> Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>
> Signed-off-by: Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>

This is messy. Ack + SoB from Michal. Two xilinx-SoBs from you. Please
fix.

Attachment: signature.asc
Description: PGP signature