Re: [PATCH 14/28] ata: move ata_dev_config_ncq*() to libata-core-sata.c

[Christoph Hellwig]

On Tue, Jan 28, 2020 at 02:33:29PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * move ata_log_supported() to libata.h and make it inline
> 
> * move ata_dev_config_ncq*() to libata-core-sata.c
> 
> * add static inline version of ata_dev_config_ncq() for
>   CONFIG_SATA_HOST=n case

Wouldn't it be easier to throw in an IS_ENABLED() into the
ATA_FLAG_FPDMA_AUX before calling ata_dev_config_ncq_* and let the
compiler optimize out the functions?