Re: [PATCH 4/4] crypto: ccree - fix AEAD blocksize registration

From: Geert Uytterhoeven
Date: Wed Jan 29 2020 - 10:17:28 EST


Hi Gilad,

On Wed, Jan 29, 2020 at 3:39 PM Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx> wrote:
> Fix an error causing no block sizes to be reported during
> all AEAD registrations.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>

Thanks, this fixes:

alg: aead: blocksize for authenc-hmac-sha1-cbc-aes-ccree (0)
doesn't match generic impl (16)
alg: aead: blocksize for authenc-hmac-sha256-cbc-aes-ccree (0)
doesn't match generic impl (16)

which you may want to mention in the commit description, so
people who search for the error message will find the fix.

Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Note that even after applying this series, the kernel still crashes with

kernel BUG at kernel/dma/swiotlb.c:497!
....
Call trace:
swiotlb_tbl_map_single+0x30c/0x380
swiotlb_map+0xb0/0x300
dma_direct_map_page+0xb8/0x140
dma_direct_map_sg+0x78/0xe0
cc_map_sg+0xa0/0xd0
cc_aead_chain_data.constprop.25+0x17c/0x6a0
cc_map_aead_request+0x61c/0x990
cc_proc_aead+0x140/0xeb0
cc_aead_decrypt+0x48/0x68
crypto_aead_decrypt+0x30/0x48
test_aead_vec_cfg+0x5a0/0x8d0

but you may be aware of that.

CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds