Re: [PATCH] x86/resctrl: fix redundant task movement

From: Fenghua Yu
Date: Tue Jan 28 2020 - 19:49:01 EST


On Tue, Jan 28, 2020 at 04:22:22PM -0800, Shakeel Butt wrote:
> Currently a task can be moved to a rdtgroup multiple times or between
> resource or monitoring groups. This can cause multiple task works are
> added, waste memory and degrade performance.
>
> To fix the issue, only move the task to a rdtgroup when the task
> is not in the rdgroup. Don't try to move the task to the rdtgroup
> again when the task is already in the rdtgroup.

Hi, Shakeel,

Acutally we are working on replacing the callback by a synchronous way
to update closid and rmid when moving a task to a resource group. The
reason is the task may use old (even invalid) closid and rmid before
they are updated.

With the new way to update closid and rmid, the issues related to
the callbacks will be fixed as well.

We will release the new patches soon.

Thanks.

-Fenghua