[PATCH 4.9 266/271] bcache: silence static checker warning

From: Greg Kroah-Hartman
Date: Tue Jan 28 2020 - 09:32:47 EST


From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

commit da22f0eea555baf9b0a84b52afe56db2052cfe8d upstream.

In olden times, closure_return() used to have a hidden return built in.
We removed the hidden return but forgot to add a new return here. If
"c" were NULL we would oops on the next line, but fortunately "c" is
never NULL. Let's just remove the if statement.

Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Reviewed-by: Coly Li <colyli@xxxxxxx>
Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
drivers/md/bcache/super.c | 3 ---
1 file changed, 3 deletions(-)

--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1398,9 +1398,6 @@ static void cache_set_flush(struct closu
struct btree *b;
unsigned i;

- if (!c)
- closure_return(cl);
-
bch_cache_accounting_destroy(&c->accounting);

kobject_put(&c->internal);