Re: [PATCH] dt-bindings: fix compilation error of the example in intel,lgm-emmc-phy.yaml

From: Kishon Vijay Abraham I
Date: Mon Jan 27 2020 - 07:21:23 EST




On 24/01/20 7:59 pm, Dafna Hirschfeld wrote:
>
>
> On 24.01.20 15:03, Rob Herring wrote:
>> On Fri, Jan 24, 2020 at 5:49 AM Dafna Hirschfeld
>> <dafna.hirschfeld@xxxxxxxxxxxxx> wrote:
>>>
>>> Running:
>>> export
>>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml
>>>
>>> 'make dt_binding_check'
>>>
>>> gives a compilation error. This is because in the example there
>>> is the label 'emmc-phy' but labels are not allowed to have '-' sing.
>>> Replace the '-' with '_' to fix the error.
>>>
>>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
>>
>> There's a fix from the author, but you're first to get the fix
>> correct, so:
> Oh, sorry, I was not aware of that.
> Dafna
>
>>
>> Fixes: 5bc999108025 ("dt-bindings: phy: intel-emmc-phy: Add YAML
>> schema for LGM eMMC PHY")
>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>>
>> Kishon, Please apply these soon as linux-next is broken.
>>

merged now, Thanks!

-Kishon