Re: [PATCH] OCFS2: remove dlm_lock_is_remote

From: Joseph Qi
Date: Sat Jan 25 2020 - 20:49:03 EST




On 20/1/21 11:43, Alex Shi wrote:
> This macros is also not used from it was introduced. better to remove
> it.
>
> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>
> Cc: Mark Fasheh <mark@xxxxxxxxxx>
> Cc: Joel Becker <jlbec@xxxxxxxxxxxx>
> Cc: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
> Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Richard Fontana <rfontana@xxxxxxxxxx>
> Cc: ocfs2-devel@xxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

Acked-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>
> ---
> fs/ocfs2/dlm/dlmthread.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
> index 2dd9727537fe..0da9ffc40a88 100644
> --- a/fs/ocfs2/dlm/dlmthread.c
> +++ b/fs/ocfs2/dlm/dlmthread.c
> @@ -39,8 +39,6 @@
> static int dlm_thread(void *data);
> static void dlm_flush_asts(struct dlm_ctxt *dlm);
>
> -#define dlm_lock_is_remote(dlm, lock) ((lock)->ml.node != (dlm)->node_num)
> -
> /* will exit holding res->spinlock, but may drop in function */
> /* waits until flags are cleared on res->state */
> void __dlm_wait_on_lockres_flags(struct dlm_lock_resource *res, int flags)
>