Re: [PATCH v2 kunit-next 0/3] kunit: add debugfs representation to show results/run tests

From: Brendan Higgins
Date: Thu Jan 23 2020 - 17:24:20 EST


+Luis Chamberlain

On Thu, Jan 23, 2020 at 10:47 AM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote:
>
> When kunit tests are run on native (i.e. non-UML) environments, the results
> of test execution are often intermixed with dmesg output. This patch
> series attempts to solve this by providing a debugfs representation
> of the results of the last test run, available as
>
> /sys/kernel/debug/kunit/<testsuite>/results
>
> In addition, we provide a way to re-run the tests and show results via
>
> /sys/kernel/debug/kunit/<testsuite>/run

Ooo, cool! I like this! I was actually thinking about doing something
similar after talking to either Shuah, or Luis, so this is great! I
think Luis will be interested in this regardless so I cc'ed him.

> Changes since v1:
> - trimmed unneeded include files in lib/kunit/debugfs.c (Greg)
> - renamed global debugfs functions to be prefixed with kunit_ (Greg)
> - removed error checking for debugfs operations (Greg)
>
> Alan Maguire (3):
> kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display
> kunit: add "run" debugfs file to run suites, display results
> kunit: update documentation to describe debugfs representation
>
> Documentation/dev-tools/kunit/usage.rst | 19 +++++
> include/kunit/test.h | 21 +++--
> lib/kunit/Makefile | 3 +-
> lib/kunit/debugfs.c | 137 ++++++++++++++++++++++++++++++++
> lib/kunit/debugfs.h | 16 ++++
> lib/kunit/test.c | 85 +++++++++++++++-----
> 6 files changed, 254 insertions(+), 27 deletions(-)
> create mode 100644 lib/kunit/debugfs.c
> create mode 100644 lib/kunit/debugfs.h
>
> --
> 1.8.3.1
>