Re: [Patch v8 1/7] sched/pelt: Add support to track thermal pressure

From: Dietmar Eggemann
Date: Thu Jan 23 2020 - 14:15:52 EST


On 16/01/2020 16:17, Peter Zijlstra wrote:
> On Tue, Jan 14, 2020 at 02:57:33PM -0500, Thara Gopinath wrote:
>
>> diff --git a/kernel/sched/pelt.h b/kernel/sched/pelt.h
>> index afff644..bf1e17b 100644
>> --- a/kernel/sched/pelt.h
>> +++ b/kernel/sched/pelt.h
>> @@ -7,6 +7,16 @@ int __update_load_avg_cfs_rq(u64 now, struct cfs_rq *cfs_rq);
>> int update_rt_rq_load_avg(u64 now, struct rq *rq, int running);
>> int update_dl_rq_load_avg(u64 now, struct rq *rq, int running);
>>
>> +#ifdef CONFIG_HAVE_SCHED_THERMAL_PRESSURE

I assume your plan is to enable this for Arm and Arm64? Otherwise the
code in 3/7 should also be guarded by this.

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index e688dfad0b72..9eb414b2c8b9 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -164,6 +164,7 @@ config ARM64
select HAVE_FUNCTION_ARG_ACCESS_API
select HAVE_RCU_TABLE_FREE
select HAVE_RSEQ
+ select HAVE_SCHED_THERMAL_PRESSURE
select HAVE_STACKPROTECTOR
select HAVE_SYSCALL_TRACEPOINTS

Currently it lives in the 'CPU/Task time and stats accounting' of
.config which doesn't feel right to me.

[...]