Re: [PATCH] module.h: Annotate mod_kallsyms with __rcu

[Jessica Yu]

+++ madhuparnabhowmik10@xxxxxxxxx [22/01/20 22:34 +0530]:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>
>
> This patch fixes the following sparse errors:
>
> kernel/module.c:3623:9: error: incompatible types in comparison expression
> kernel/module.c:4060:41: error: incompatible types in comparison expression
> kernel/module.c:4203:28: error: incompatible types in comparison expression
> kernel/module.c:4225:41: error: incompatible types in comparison expression
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>

Hi Madhuparna,

Thanks, I can confirm this patch fixes the sparse warnings. I've
applied it to modules-next.

Jessica

> ---
> include/linux/module.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index bd165ba68617..dfdc8863e26a 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -429,7 +429,7 @@ struct module {
>
> #ifdef CONFIG_KALLSYMS
> 	/* Protected by RCU and/or module_mutex: use rcu_dereference() */
> -	struct mod_kallsyms *kallsyms;
> +	struct mod_kallsyms __rcu *kallsyms;
> 	struct mod_kallsyms core_kallsyms;
>
> 	/* Section attributes */
> --
> 2.17.1