Re: [PATCH bpf 2/4] selftests: bpf: ignore RST packets for reuseport tests

From: Lorenz Bauer
Date: Thu Jan 23 2020 - 12:18:26 EST


On Thu, 23 Jan 2020 at 17:16, Martin Lau <kafai@xxxxxx> wrote:
>
> On Thu, Jan 23, 2020 at 04:59:31PM +0000, Lorenz Bauer wrote:
> > The reuseport tests currently suffer from a race condition: RST
> > packets count towards DROP_ERR_SKB_DATA, since they don't contain
> > a valid struct cmd. Tests will spuriously fail depending on whether
> > check_results is called before or after the RST is processed.
> >
> > Exit the BPF program early if FIN is set.
> Make sense.
> Is it a RST or FIN? The earlier commit message said RST.

FIN, sorry. I'll update in a follow up.

--
Lorenz Bauer | Systems Engineer
6th Floor, County Hall/The Riverside Building, SE1 7PB, UK

www.cloudflare.com