Re: [PATCH] dt-binding: fix compilation error of the example in qcom,gcc.yaml

[Rob Herring]

On Wed, Jan 22, 2020 at 7:46 AM Dafna Hirschfeld
<dafna.hirschfeld@xxxxxxxxxxxxx> wrote:
>
> Running `make dt_binging_check`, gives the error:
>
> DTC     Documentation/devicetree/bindings/clock/qcom,gcc.example.dt.yaml
> Error: Documentation/devicetree/bindings/clock/qcom,gcc.example.dts:111.28-29 syntax error
> FATAL ERROR: Unable to parse input tree
>
> This is because the last example uses the macro RPM_SMD_XO_CLK_SRC which
> is defined in qcom,rpmcc.h but the include of this header is missing.
> Add the include to fix the error.
>

Fixes: d109ea0970cf ("dt-bindings: clock: Document external clocks for
MSM8998 gcc")
Acked-by: Rob Herring <robh@xxxxxxxxxx>

> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@xxxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 19d00794fe7d..50ff07f80acb 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -220,6 +220,7 @@ examples:
>
>    # Example of MSM8998 GCC:
>    - |
> +    #include <dt-bindings/clock/qcom,rpmcc.h>
>      clock-controller@100000 {
>        compatible = "qcom,gcc-msm8998";
>        #clock-cells = <1>;
> --
> 2.17.1
>