Re: [PATCH v10 1/2] dt-bindings: edac: dmc-520.yaml

From: Rob Herring
Date: Thu Jan 23 2020 - 08:48:28 EST


On Wed, Jan 22, 2020 at 6:31 PM Shiping Ji <shiping.linux@xxxxxxxxx> wrote:
>
> This is the device tree bindings for new EDAC driver dmc520_edac.c.
>
> From: Lei Wang <leiwang_git@xxxxxxxxxxx>
>
> Signed-off-by: Lei Wang <leiwang_git@xxxxxxxxxxx>
> Signed-off-by: Shiping Ji <shiping.linux@xxxxxxxxx>
> Reviewed-by: James Morse <james.morse@xxxxxxx>
>
> ---
> Changes in v10:
> - Convert to the YAML format for binding description
>
> ---
> .../devicetree/bindings/edac/dmc-520.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/dmc-520.yaml
>
> diff --git a/Documentation/devicetree/bindings/edac/dmc-520.yaml b/Documentation/devicetree/bindings/edac/dmc-520.yaml
> new file mode 100644
> index 000000000000..dd5982b227b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/edac/dmc-520.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/edac/dmc-520.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM DMC-520 EDAC bindings
> +
> +maintainers:
> + - Lei Wang <lewan@xxxxxxxxxxxxx>
> +
> +description: |+
> + DMC-520 node is defined to describe DRAM error detection and correction.
> +
> + https://static.docs.arm.com/100000/0200/corelink_dmc520_trm_100000_0200_01_en.pdf
> +
> +properties:
> + compatible:
> + items:
> + - const: brcm,dmc-520
> + - const: arm,dmc-520
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 1

You also need 'maxItems: 10' here.