Re: [PATCH] drm/stm: dsi: stm mipi dsi doesn't print error on probe deferral

From: Philippe CORNU
Date: Thu Jan 23 2020 - 04:54:43 EST


Dears Yannick & Etienne,
Thank you for your patch,

Reviewed-by: Philippe Cornu <philippe.cornu@xxxxxx>

Philippe :-)

On 1/21/20 11:24 AM, Yannick Fertre wrote:
> From: Etienne Carriere <etienne.carriere@xxxxxx>
>
> Change DSI driver to not print an error trace when probe
> is deferred for a clock resource.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@xxxxxx>
> ---
> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 4b16563..2e1f266 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -377,7 +377,9 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
> dsi->pllref_clk = devm_clk_get(dev, "ref");
> if (IS_ERR(dsi->pllref_clk)) {
> ret = PTR_ERR(dsi->pllref_clk);
> - DRM_ERROR("Unable to get pll reference clock: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + DRM_ERROR("Unable to get pll reference clock: %d\n",
> + ret);
> goto err_clk_get;
> }
>
>