Re: Linux 4.19.98

[Greg KH]

On Thu, Jan 23, 2020 at 08:54:45AM +0000, Chris Wilson wrote:
> Quoting Greg KH (2020-01-23 08:46:32)
> > I'm announcing the release of the 4.19.98 kernel.
> 
> commit 3e6b472f474accf757e107919f8ee42e7315ac0d
> Author: Waiman Long <longman@xxxxxxxxxx>
> Date:   Wed Nov 14 09:55:40 2018 -0800
> 
>     efi: Fix debugobjects warning on 'efi_rts_work'
> 
>     [ Upstream commit ef1491e791308317bb9851a0ad380c4a68b58d54 ]
> 
>     The following commit:
> 
>       9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler")
> 
>     converted 'efi_rts_work' from an auto variable to a global variable.
>     However, when submitting the work, INIT_WORK_ONSTACK() was still used,
>     causing the following complaint from debugobjects:
> 
>       ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but annotated.
> 
>     Change the macro to just INIT_WORK() to eliminate the warning.
> 
>     Signed-off-by: Waiman Long <longman@xxxxxxxxxx>
>     Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>     Acked-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@xxxxxxxxx>
>     Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>     Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>     Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>     Cc: linux-efi@xxxxxxxxxxxxxxx
>     Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler")
>     Link: http://lkml.kernel.org/r/20181114175544.12860-2-ard.biesheuvel@xxxxxxxxxx
>     Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
>     Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> 
> was incorrectly applied to v4.19.41 and causes lockdep complaints for
> the onstack efi_rts_work being initialised by INIT_WORK().

Incorrectly how?  Fuzz off, or it shouldn't be applied at all?  Should
this be reverted, or just fixed up, and if fixed up, do you have a patch
to fix it?

thanks,

greg k-h