Re: [PATCH] KVM: nVMX: delete meaningless nested_vmx_run() declaration

From: Vitaly Kuznetsov
Date: Thu Jan 23 2020 - 03:19:06 EST


linmiaohe <linmiaohe@xxxxxxxxxx> writes:

> From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>
> The function nested_vmx_run() declaration is below its implementation. So
> this is meaningless and should be removed.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ---
> arch/x86/kvm/vmx/nested.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 95b3f4306ac2..7608924ee8c1 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -4723,8 +4723,6 @@ static int handle_vmclear(struct kvm_vcpu *vcpu)
> return nested_vmx_succeed(vcpu);
> }
>
> -static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch);
> -
> /* Emulate the VMLAUNCH instruction */
> static int handle_vmlaunch(struct kvm_vcpu *vcpu)
> {

Reviewed-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

--
Vitaly