Re: [PATCH] mm: move_pages: report the number of non-attempted pages

From: Yang Shi
Date: Wed Jan 22 2020 - 17:43:38 EST




On 1/22/20 2:05 PM, Andrew Morton wrote:
On Thu, 23 Jan 2020 03:39:50 +0800 Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx> wrote:

Since commit a49bd4d71637 ("mm, numa: rework do_pages_move"),
the semantic of move_pages() was changed to return the number of
non-migrated pages (failed to migration) and the call would be aborted
immediately if migrate_pages() returns positive value. But it didn't
report the number of pages that we even haven't attempted to migrate.
So, fix it by including non-attempted pages in the return value.

Fixes: a49bd4d71637 ("mm, numa: rework do_pages_move")
Suggested-by: Michal Hocko <mhocko@xxxxxxxx>
Cc: Wei Yang <richardw.yang@xxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> [4.17+]
Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxxxxxxxxx>
---
The patch is based off Wei Yang's cleanup patchset:
https://lore.kernel.org/linux-mm/20200122011647.13636-1-richardw.yang@xxxxxxxxxxxxxxx/T/#t
Can you please redo this so it is applicable to current mainline? That
will make it more easily backportable and this fix is higher priority
than a set of cleanups.

Sure.