Re: [PATCH v2 4/4] RISC-V: Select Goldfish RTC driver for QEMU virt machine

From: Paul Walmsley
Date: Wed Jan 22 2020 - 14:50:03 EST


On Tue, 3 Dec 2019, Anup Patel wrote:

> We select Goldfish RTC driver using QEMU virt machine kconfig option
> to access RTC device on QEMU virt machine.
>
> Signed-off-by: Anup Patel <anup.patel@xxxxxxx>
> Reviewed-by: Atish Patra <atish.patra@xxxxxxx>
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@xxxxxxxxxx>

I just grepped for Goldfish through the QEMU git tree, and it didn't come
up with anything. Per our discussion last year: as a general matter of
policy, until QEMU merges support for a simulated hardware device into
their master branch, we shouldn't speculatively enable support for it.
So, NAK from me on this one until that happens.


- Paul