Re: [PATCH 1/3] arm64: dts: allwinner: h6: tanix-tx6: enable emmc

[Maxime Ripard]

Hi,

On Fri, Jan 17, 2020 at 07:18:58PM +0100, Jernej Åkrabec wrote:
> Dne petek, 17. januar 2020 ob 19:14:27 CET je Maxime Ripard napisal(a):
> > On Wed, Jan 15, 2020 at 08:34:41PM +0100, Jernej Skrabec wrote:
> > > Tanix TX6 has 32 GiB eMMC. Add a node for it.
> > >
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>
> > > ---
> > >
> > >  .../dts/allwinner/sun50i-h6-tanix-tx6.dts     | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > > b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts index
> > > 83e6cb0e59ce..8cbf4e4a761e 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts
> > > @@ -31,6 +31,13 @@ hdmi_con_in: endpoint {
> > >
> > >  		};
> > >
> > >  	};
> > >
> > > +	reg_vcc1v8: vcc1v8 {
> > > +		compatible = "regulator-fixed";
> > > +		regulator-name = "vcc1v8";
> > > +		regulator-min-microvolt = <1800000>;
> > > +		regulator-max-microvolt = <1800000>;
> > > +	};
> > > +
> > >
> > >  	reg_vcc3v3: vcc3v3 {
> > >
> > >  		compatible = "regulator-fixed";
> > >  		regulator-name = "vcc3v3";
> > >
> > > @@ -78,6 +85,15 @@ &mmc0 {
> > >
> > >  	status = "okay";
> > >
> > >  };
> > >
> > > +&mmc2 {
> > > +	vmmc-supply = <&reg_vcc3v3>;
> > > +	vqmmc-supply = <&reg_vcc1v8>;
> > > +	non-removable;
> > > +	cap-mmc-hw-reset;
> > > +	bus-width = <8>;
> > > +	status = "okay";
> > > +};
> > > +
> > >
> > >  &ohci0 {
> > >
> > >  	status = "okay";
> > >
> > >  };
> > >
> > > @@ -86,6 +102,10 @@ &ohci3 {
> > >
> > >  	status = "okay";
> > >
> > >  };
> > >
> > > +&pio {
> > > +	vcc-pc-supply = <&reg_vcc1v8>;
> > > +};
> > > +
> >
> > Can you list all of the regulators for the H6 while you're at it (in a
> > preliminary patch, ideally)?
>
> Not sure what you mean. This box has only fixed regulators. I deducted above
> from the fact that port C is mostly dedicated to eMMC, so it has to use same
> regulator as vqmmc. Other than that, I don't know.

If you don't really know, then setting all of them to 3.3v makes the
most sense. It should be described anyway.

Maxime

Attachment: signature.asc
Description: PGP signature