Re: [PATCH v2] bpf: btf: Always output invariant hit in pahole DWARF to BTF transform

From: Daniel Borkmann
Date: Wed Jan 22 2020 - 12:24:05 EST


On 1/22/20 1:01 AM, Chris Down wrote:
When trying to compile with CONFIG_DEBUG_INFO_BTF enabled, I got this
error:

% make -s
Failed to generate BTF for vmlinux
Try to disable CONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1

Compiling again without -s shows the true error (that pahole is
missing), but since this is fatal, we should show the error
unconditionally on stderr as well, not silence it using the `info`
function. With this patch:

% make -s
BTF: .tmp_vmlinux.btf: pahole (pahole) is not available
Failed to generate BTF for vmlinux
Try to disable CONFIG_DEBUG_INFO_BTF
make[3]: *** [vmlinux] Error 1

Signed-off-by: Chris Down <chris@xxxxxxxxxxxxxx>
Cc: Stanislav Fomichev <sdf@xxxxxxxxxx>
Cc: Andrii Nakryiko <andriin@xxxxxx>
Cc: John Fastabend <john.fastabend@xxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: netdev@xxxxxxxxxxxxxxx
Cc: bpf@xxxxxxxxxxxxxxx
Cc: kernel-team@xxxxxx

Applied, thanks!