Re: [PATCH 1/3] dt-bindings: net: can: m_can: Add Documentation for stb-gpios

[Dan Murphy]

Sekhar

On 1/22/20 8:24 AM, Sekhar Nori wrote:
> On 22/01/20 7:05 PM, Dan Murphy wrote:
> > Faiz
> >
> > On 1/22/20 2:03 AM, Faiz Abbas wrote:
> > > The CAN transceiver on some boards has an STB pin which is
> > > used to control its standby mode. Add an optional property
> > > stb-gpios to toggle the same.
> > >
> > > Signed-off-by: Faiz Abbas <faiz_abbas@xxxxxx>
> > > Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
> > > ---
> > >  Â Documentation/devicetree/bindings/net/can/m_can.txt | 2 ++
> > >  Â 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt
> > > b/Documentation/devicetree/bindings/net/can/m_can.txt
> > > index ed614383af9c..cc8ba3f7a2aa 100644
> > > --- a/Documentation/devicetree/bindings/net/can/m_can.txt
> > > +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
> > > @@ -48,6 +48,8 @@ Optional Subnode:
> > >  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ that can be used for CAN/CAN-FD modes. See
> > >                 
> > > Documentation/devicetree/bindings/net/can/can-transceiver.txt
> > >  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ for details.
> > > +stb-gpiosÂÂÂÂÂÂÂ : gpio node to toggle the STB (standby) signal on
> > > the transceiver
> > > +
> > The m_can.txt is for the m_can framework. If this is specific to the
> > platform then it really does not belong here.
> >
> > If the platform has specific nodes then maybe we need a
> > m_can_platform.txt binding for specific platform nodes. But I leave
> > that decision to Rob.
> Since this is transceiver enable, should this not be in
> Documentation/devicetree/bindings/net/can/can-transceiver.txt?

+1

Dan