Re: [PATCH RESEND -next] tee: amdtee: amdtee depends on CRYPTO_DEV_CCP_DD

[Jens Wiklander]

On Wed, Jan 22, 2020 at 10:17 AM Hongbo Yao <yaohongbo@xxxxxxxxxx> wrote:
>
> If CRYPTO_DEV_CCP_DD=m and AMDTEE=y, the following error is seen
> while building call.c or core.c
>
> drivers/tee/amdtee/call.o: In function `handle_unload_ta':
> call.c:(.text+0x35f): undefined reference to `psp_tee_process_cmd'
> drivers/tee/amdtee/core.o: In function `amdtee_driver_init':
> core.c:(.init.text+0xf): undefined reference to `psp_check_tee_status
>
> Fix the config dependency for AMDTEE here.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Fixes: 757cc3e9ff ("tee: add AMD-TEE driver")
> Signed-off-by: Hongbo Yao <yaohongbo@xxxxxxxxxx>
> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@xxxxxxx>
> ---
>  drivers/tee/amdtee/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>

Thanks,
Jens

>
> diff --git a/drivers/tee/amdtee/Kconfig b/drivers/tee/amdtee/Kconfig
> index 4e32b6413b41..191f9715fa9a 100644
> --- a/drivers/tee/amdtee/Kconfig
> +++ b/drivers/tee/amdtee/Kconfig
> @@ -3,6 +3,6 @@
>  config AMDTEE
>         tristate "AMD-TEE"
>         default m
> -       depends on CRYPTO_DEV_SP_PSP
> +       depends on CRYPTO_DEV_SP_PSP && CRYPTO_DEV_CCP_DD
>         help
>           This implements AMD's Trusted Execution Environment (TEE) driver.
> --
> 2.20.1
>