Re: [PATCH] iommu/vt-d: call __dmar_remove_one_dev_info with valid pointer

[Lu Baolu]

On 1/22/20 8:34 AM, Jerry Snitselaar wrote:
> It is possible for archdata.iommu to be set to
> DEFER_DEVICE_DOMAIN_INFO or DUMMY_DEVICE_DOMAIN_INFO so check for
> those values before calling __dmar_remove_one_dev_info. Without a
> check it can result in a null pointer dereference. This has been seen
> while booting a kdump kernel on an HP dl380 gen9.
>
> Cc: Joerg Roedel <joro@xxxxxxxxxx>
> Cc: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # 5.3+
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Fixes: ae23bfb68f28 ("iommu/vt-d: Detach domain before using a private one")
> Signed-off-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>

Acked-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>

Best regards,
baolu