Re: [PATCH] x86/fpu: remove unused macros

[Dave Hansen]

On 1/21/20 3:43 AM, Cyrill Gorcunov wrote:
> On Tue, Jan 21, 2020 at 04:50:11PM +0800, Alex Shi wrote:
>> NR_VALID_PKRU_BITS/PKRU_VALID_MASK are never used after it was
>> introduced. So better to remove them.
> Dave moved them in so while they are not used indeed better to
> get approve from him (to be sure they were not reserved for
> future development).
> 
> Initial commit 8459429693395ca9e8d18101300b120ad9171795

FWIW, I'm not a massive fan of blindly removing stuff like this.  Maybe
it's better to remove the cruft, but it's even better to try to figure
out why I might have added them in the first place. :)

I *think* it was an attempt to ensure that a resulting PKRU value can be
written to PKRU, independent of the type it was stored as.

Let me see if I can come up with something nicer than ripping these out.