Re: [PATCH v2 1/3] alarmtimer: Make alarmtimer platform device child of RTC device

From: Stephen Boyd
Date: Tue Jan 21 2020 - 17:44:34 EST


Quoting Stephen Boyd (2020-01-21 11:48:09)
> @@ -115,10 +118,14 @@ static int alarmtimer_rtc_add_device(struct device *dev,
> get_device(dev);
> ws = __ws;
> __ws = NULL;
> + pdev = NULL;
> + } else {
> + ret = - 1;

^
Ick. This has an extra space.

> }
> unlock:
> spin_unlock_irqrestore(&rtcdev_lock, flags);
>
> + platform_device_unregister(pdev);
> wakeup_source_unregister(__ws);
>
> return ret;