Re: [PATCH v4 6/6] Documentation: ACPI: Document probe-low-power _DSD property

From: Sakari Ailus
Date: Tue Jan 21 2020 - 11:59:07 EST


On Tue, Jan 21, 2020 at 05:56:39PM +0100, Rafael J. Wysocki wrote:
> On Tue, Jan 21, 2020 at 5:19 PM Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Jan 21, 2020 at 05:09:44PM +0100, Rafael J. Wysocki wrote:
> > > On Tue, Jan 21, 2020 at 2:41 PM Sakari Ailus
> > > <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> > > >
> > > > Document the probe-low-power _DSD property and how it is used with I²C
> > > > drivers.
> > > >
> > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > > > ---
> > > > .../acpi/dsd/probe-low-power.rst | 28 +++++++++++++++++++
> > > > Documentation/firmware-guide/acpi/index.rst | 1 +
> > > > 2 files changed, 29 insertions(+)
> > > > create mode 100644 Documentation/firmware-guide/acpi/dsd/probe-low-power.rst
> > > >
> > > > diff --git a/Documentation/firmware-guide/acpi/dsd/probe-low-power.rst b/Documentation/firmware-guide/acpi/dsd/probe-low-power.rst
> > > > new file mode 100644
> > > > index 0000000000000..e0343ffefe071
> > > > --- /dev/null
> > > > +++ b/Documentation/firmware-guide/acpi/dsd/probe-low-power.rst
> > > > @@ -0,0 +1,28 @@
> > > > +.. SPDX-License-Identifier: GPL-2.0
> > > > +
> > > > +======================================
> > > > +Probing I²C devices in low power state
> > > > +======================================
> > > > +
> > > > +Introduction
> > > > +============
> > > > +
> > > > +In some cases it may be preferred to leave certain devices powered off for
> > > > +the entire system bootup if powering on these devices has adverse side
> > > > +effects, beyond just powering on the said device. The _DSD property
> > > > +"probe-low-power" has been defined for this purpose.
> > >
> > > Well, if you say "has been defined", you need to provide a pointer to
> > > the definition document (a specification of some sort or similar).
> >
> > How about:
> >
> > s/has been defined/is used/
>
> I would say "Linux recognizes the ... that can be used for this purpose."

Ack; I'll use this in v5.

--
Sakari Ailus