Re: [PATCH v2 05/12] tracing: Add synth_event_run_command()

From: Steven Rostedt
Date: Tue Jan 21 2020 - 11:53:48 EST


On Fri, 10 Jan 2020 14:35:11 -0600
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:

> From: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>
> This snippet was taken from v4 of Masami's 'tracing/boot: Add
> synthetic event support' patch.
>
> >From the original: 'The synthetic node requires "fields" string
> arraies, which defines the fields as same as tracing/synth_events
> interface.'
>
> synth_event_run_command() provides the means to execute the synthetic
> event create command using the synthetic event command string.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>

If you base your next series off of my for-next branch, you wont need
this patch.

-- Steve


> ---
> kernel/trace/trace_events_hist.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 8c9894681100..0886ca6da255 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -1390,6 +1390,11 @@ static int create_or_delete_synth_event(int argc, char **argv)
> return ret == -ECANCELED ? -EINVAL : ret;
> }
>
> +int synth_event_run_command(const char *command)
> +{
> + return trace_run_command(command, create_or_delete_synth_event);
> +}
> +
> static int synth_event_create(int argc, const char **argv)
> {
> const char *name = argv[0];