Re: [PATCH] serial: 8250_tegra: Create Tegra specific 8250 driver

[Dmitry Osipenko]

21.01.2020 19:31, Dmitry Osipenko ÐÐÑÐÑ:
> Hello Jon,
> 
> 20.01.2020 19:01, Jon Hunter ÐÐÑÐÑ:
> 
> [snip]
> 
>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +	if (!res)
>> +		return -ENODEV;
>> +
>> +	port->membase = devm_ioremap(&pdev->dev, res->start,
>> +				     resource_size(res));
> 
> devm_platform_ioremap_resource()
> 
>> +	if (!port->membase)
>> +		return -ENOMEM;
>> +
>> +	port->mapbase = res->start;
>> +	port->mapsize = resource_size(res);
>> +
>> +	uart->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
> 
> Why reset is shared? It shall not be shared at least on T20/30/124/210..
> 
> [snip]
> 

Actually, looks like use of a shared reset for a not-really-shared reset
should be fine.