Re: [PATCH] proc: remove unused macro

[David Hildenbrand]

On 21.01.20 11:25, Alex Shi wrote:
> KPMBITS is never used from it was introduced. better to remove it.

I suggest

"fs/proc/page.c: remove unused macro KPMBITS

KPMBITS was never used since it was introduced in commit 3c3fc71c8cfa
("mm: introduce idle page tracking"). Let's remove it.
"

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

> 
> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx>
> Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx> 
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> 
> Cc: David Hildenbrand <david@xxxxxxxxxx> 
> Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx> 
> Cc: Pankaj gupta <pagupta@xxxxxxxxxx> 
> Cc: Konstantin Khlebnikov <koct9i@xxxxxxxxx> 
> Cc: linux-kernel@xxxxxxxxxxxxxxx 
> Cc: linux-fsdevel@xxxxxxxxxxxxxxx 
> ---
>  fs/proc/page.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/proc/page.c b/fs/proc/page.c
> index 7c952ee732e6..c4b1005a82bc 100644
> --- a/fs/proc/page.c
> +++ b/fs/proc/page.c
> @@ -19,7 +19,6 @@
>  
>  #define KPMSIZE sizeof(u64)
>  #define KPMMASK (KPMSIZE - 1)
> -#define KPMBITS (KPMSIZE * BITS_PER_BYTE)
>  
>  /* /proc/kpagecount - an array exposing page counts
>   *
> 


-- 
Thanks,

David / dhildenb