Re:Re: [PATCH] powerpc/sysdev: fix compile errors

[çæè]

åääïAndrew Donnellan <ajd@xxxxxxxxxxxxx>
åéææï2020-01-21 14:13:07
æääïwangwenhu <wenhu.pku@xxxxxxxxx>,Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>,Paul Mackerras <paulus@xxxxxxxxx>,Michael Ellerman <mpe@xxxxxxxxxxxxxx>,Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>,Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>,Richard Fontana <rfontana@xxxxxxxxxx>,Thomas Gleixner <tglx@xxxxxxxxxxxxx>,linuxppc-dev@xxxxxxxxxxxxxxxx,linux-kernel@xxxxxxxxxxxxxxx
æéäïtrivial@xxxxxxxxxx,lonehugo@xxxxxxxxxxx,wenhu.wang@xxxxxxxx
äéïRe: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote:
>> From: wangwenhu <wenhu.wang@xxxxxxxx>
>> 
>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to
>> fix the implicit declaration compile errors when building Cache-Sram.
>> 
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function âinstantiate_cache_sramâ:
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function âioremap_coherentâ; did you mean âbitmap_complementâ? [-Werror=implicit-function-declaration]
>>    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>                            ^~~~~~~~~~~~~~~~
>>                            bitmap_complement
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion]
>>    cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys,
>>                          ^
>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function âiounmapâ; did you mean âroundupâ? [-Werror=implicit-function-declaration]
>>    iounmap(cache_sram->base_virt);
>>    ^~~~~~~
>>    roundup
>> cc1: all warnings being treated as errors
>> 
>> Signed-off-by: wangwenhu <wenhu.wang@xxxxxxxx>
>
>How long has this code been broken for?

It's been broken almost 15 months since the commit below:
"commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1
Author: Christophe Leroy <christophe.leroy@xxxxxx>
Date:   Tue Oct 9 13:51:41 2018 +0000

    powerpc: don't use ioremap_prot() nor __ioremap() unless really needed."

And we are working on it now for further development.

>
>> ---
>>   arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> index f6c665dac725..29b6868eff7d 100644
>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c
>> @@ -17,6 +17,7 @@
>>   #include <linux/of_platform.h>
>>   #include <asm/pgtable.h>
>>   #include <asm/fsl_85xx_cache_sram.h>
>> +#include <asm/io.h>
>> 
>>   #include "fsl_85xx_cache_ctlr.h"
>> 
>
>-- 
>Andrew Donnellan              OzLabs, ADL Canberra
>ajd@xxxxxxxxxxxxx             IBM Australia Limited
>

Wenhu