Re: [PATCH v4 5/8] scsi: ufs: Inline two functions into their callers

[Asutosh Das (asd)]

On 1/20/2020 5:08 AM, Bean Huo wrote:
> From: Bean Huo <beanhuo@xxxxxxxxxx>
>
> Delete ufshcd_read_power_desc() and ufshcd_read_device_desc(), directly
> inline ufshcd_read_desc() into its callers.
>
> Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
> ---

LGTM.
Reviewed-by: Asutosh Das <asutoshd@xxxxxxxxxxxxxx>

>   drivers/scsi/ufs/ufshcd.c | 17 ++++-------------
>   1 file changed, 4 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 5dfe760f2786..3d3289bb3cad 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -3146,17 +3146,6 @@ static inline int ufshcd_read_desc(struct ufs_hba *hba,
>   	return ufshcd_read_desc_param(hba, desc_id, desc_index, 0, buf, size);
>   }
>   
> -static inline int ufshcd_read_power_desc(struct ufs_hba *hba,
> -					 u8 *buf,
> -					 u32 size)
> -{
> -	return ufshcd_read_desc(hba, QUERY_DESC_IDN_POWER, 0, buf, size);
> -}
> -
> -static int ufshcd_read_device_desc(struct ufs_hba *hba, u8 *buf, u32 size)
> -{
> -	return ufshcd_read_desc(hba, QUERY_DESC_IDN_DEVICE, 0, buf, size);
> -}
>   
>   /**
>    * struct uc_string_id - unicode string
> @@ -6493,7 +6482,8 @@ static void ufshcd_init_icc_levels(struct ufs_hba *hba)
>   	if (!desc_buf)
>   		return;
>   
> -	ret = ufshcd_read_power_desc(hba, desc_buf, buff_len);
> +	ret = ufshcd_read_desc(hba, QUERY_DESC_IDN_POWER, 0,
> +			desc_buf, buff_len);
>   	if (ret) {
>   		dev_err(hba->dev,
>   			"%s: Failed reading power descriptor.len = %d ret = %d",
> @@ -6599,7 +6589,8 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
>   		goto out;
>   	}
>   
> -	err = ufshcd_read_device_desc(hba, desc_buf, hba->desc_size.dev_desc);
> +	err = ufshcd_read_desc(hba, QUERY_DESC_IDN_DEVICE, 0, desc_buf,
> +			hba->desc_size.dev_desc);
>   	if (err) {
>   		dev_err(hba->dev, "%s: Failed reading Device Desc. err = %d\n",
>   			__func__, err);


--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project