Re: [PATCH 5/5] input: joystick: Add ADC attached joystick driver.

[Dmitry Torokhov]

On Sat, Jan 11, 2020 at 11:54:40AM +0000, Jonathan Cameron wrote:
> On Sun,  5 Jan 2020 01:16:39 +0100
> Artur Rojek <contact@xxxxxxxxxxxxxx> wrote:
> 
> > Add a driver for joystick devices connected to ADC controllers
> > supporting the Industrial I/O subsystem.
> > 
> > Signed-off-by: Artur Rojek <contact@xxxxxxxxxxxxxx>
> > Tested-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> 
> Looks pretty good, but I'd like to see a little more sanity checking
> on probe that the channels are in a format this driver can actually
> handle.  Given we can check channel size and consistency etc early
> it would be better to fail to probe than just report error data later.

Artur,

>From my POV it looks decent so as soon as you address Jonathan requests
you can add

Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

assuming you want it to be perged through IIO tree.

Thanks.

-- 
Dmitry