Re: [PATCH v2 2/2] regmap: stop splitting writes to non incrementing registers

From: Mark Brown
Date: Mon Jan 20 2020 - 13:09:51 EST


On Sat, Jan 18, 2020 at 08:56:25PM +0000, Ben Whitten wrote:
> When writing to non incrementing registers we should not split
> the writes in any way, writing in one transaction.

That's not an obviously true statement. If the user is intentionally
writing to a non-incrementing register and intends to stuff a block of
data into that one register via regmap_noinc_write() then sure but if
we've come in through a path that isn't specifically for the device or
is using one of the generic APIs then it's going to expect that the
framework will hide the unfortunate choices of the chip implementors and
split the I/O up.

Attachment: signature.asc
Description: PGP signature