Re: [RFC] Revert "kvm: nVMX: Restrict VMX capability MSR changes"

From: Paolo Bonzini
Date: Mon Jan 20 2020 - 11:40:15 EST


On 20/01/20 17:33, Vitaly Kuznetsov wrote:
>> I think this should be fixed in QEMU, by doing KVM_SET_MSRS for feature
>> MSRs way earlier. I'll do it since I'm currently working on a patch to
>> add a KVM_SET_MSR for the microcode revision.
> Works for me, thanks)
>
> The bigger issue is that the vCPU setup sequence (like QEMU's
> kvm_arch_put_registers()) effectively becomes an API convention and as
> it gets more complex it would be great to document it for KVM.

Indeed, it's tricky to get right. Though this is smaller compared to
the issue of the ordering between VCPU events and everything else.

Paolo