Re: [PATCH] kernel/events: Add a missing prototype for arch_perf_update_userpage()

From: Peter Zijlstra
Date: Mon Jan 20 2020 - 10:31:34 EST


On Thu, Jan 09, 2020 at 02:13:51PM +0100, Benjamin Thiel wrote:
> ... in order to fix a -Wmissing-prototype warning.
>
> No functional changes.
>
> Signed-off-by: Benjamin Thiel <b.thiel@xxxxxxxxx>
> ---
> include/linux/perf_event.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 6d4c22aee384..de3874271814 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -1544,4 +1544,7 @@ int perf_event_exit_cpu(unsigned int cpu);
> #define perf_event_exit_cpu NULL
> #endif
>
> +void __weak arch_perf_update_userpage(
> + struct perf_event *event, struct perf_event_mmap_page *userpg, u64 now);
> +

Indeed so, I've slightly changed to:

+extern void __weak arch_perf_update_userpage(struct perf_event *event,
+ struct perf_event_mmap_page *userpg,
+ u64 now);

Thanks!