Re: [PATCH v3 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW

From: Heikki Krogerus
Date: Mon Jan 20 2020 - 10:05:17 EST


On Mon, Jan 20, 2020 at 06:09:05AM -0800, Thomas Hebb wrote:
> commit 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Thomas Hebb <tommyhebb@xxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>
> Changes in v3:
> - Use the right stable email address
>
> Changes in v2:
> - Split fix into two patches
> - Added stable cc
>
> drivers/usb/typec/tcpm/wcove.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
> index edc271da14f4..9b745f432c91 100644
> --- a/drivers/usb/typec/tcpm/wcove.c
> +++ b/drivers/usb/typec/tcpm/wcove.c
> @@ -597,7 +597,7 @@ static const struct property_entry wcove_props[] = {
> PROPERTY_ENTRY_STRING("try-power-role", "sink"),
> PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
> PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
> - PROPERTY_ENTRY_U32("op-sink-microwatt", 15000),
> + PROPERTY_ENTRY_U32("op-sink-microwatt", 15000000),
> { }
> };
>
> --
> 2.24.1

thanks,

--
heikki