Re: [PATCH 1/3] perf annotate: Nuke privsize

[Ravi Bangoria]

On 1/20/20 3:38 PM, Jiri Olsa wrote:
> > -/*
> > - * Allocating the annotation line data with following
> > - * structure:
> > - *
> > - *    --------------------------------------
> > - *    private space | struct annotation_line
> > - *    --------------------------------------
> > - *
> > - * Size of the private space is stored in 'struct annotation_line'.
> > - *
> > - */
> > -static struct annotation_line *
> > -annotation_line__new(struct annotate_args *args, size_t privsize)
> > +static size_t disasm_line_size(int nr)
> >   {
>
> I agree we can get rid of the 'users' privsize passed from symbol__annotate,
> but could you please put it in separate patch, while keeping privsize in here?
>
> and then put the rest of the code factoring into separate patch,
> so we can see clearly the change and the benefits
>
> your new annotation_line__new should be renamed to something like
> annotation_line__init ... we keep __new suffix for functions that
> return new objects

Sure Jiri. Will resend with these changes.

- Ravi