Re: [PATCH] regulator: vctrl-regulator: Avoid deadlock getting and setting the voltage

From: Enric Balletbo i Serra
Date: Mon Jan 20 2020 - 07:10:27 EST




On 20/1/20 13:08, Mark Brown wrote:
> On Fri, Jan 17, 2020 at 07:28:04PM +0300, Dmitry Osipenko wrote:
>> 16.01.2020 12:45, Enric Balletbo i Serra ÐÐÑÐÑ:
>
>>> +EXPORT_SYMBOL(regulator_set_voltage_rdev);
>>>
>>> static int regulator_limit_voltage_step(struct regulator_dev *rdev,
>>> int *current_uV, int *min_uV)
>>> @@ -4034,6 +4035,7 @@ int regulator_get_voltage_rdev(struct regulator_dev *rdev)
>>> return ret;
>>> return ret - rdev->constraints->uV_offset;
>>> }
>>> +EXPORT_SYMBOL(regulator_get_voltage_rdev);
>
>> I think it should be EXPORT_SYMBOL_GPL().
>
> Yes, you're right.
>

Oops, right, Mark do you want me to send a follow-up patch, a second version or
you can just apply a fix?

Thanks,
Enric